Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for some nvcc versions #292

Merged
merged 7 commits into from
Sep 13, 2024
Merged

Conversation

dtaller
Copy link
Collaborator

@dtaller dtaller commented Sep 13, 2024

Sometimes nvcc won't generate constructors/assignment operators when = default is used. The workaround is to explicitly define them.

@dtaller dtaller requested review from adayton1 and liu15 September 13, 2024 16:15
src/care/host_device_map.h Outdated Show resolved Hide resolved
@liu15
Copy link
Collaborator

liu15 commented Sep 13, 2024

Was this the only change needed for the offsite builds? I thought that =default was supposed to create both host and device default versions. I'm surprised that these are the only ones...

@dtaller
Copy link
Collaborator Author

dtaller commented Sep 13, 2024

Was this the only change needed for the offsite builds? I thought that =default was supposed to create both host and device default versions. I'm surprised that these are the only ones...

@liu15 Yes, this only happened on offsite builds. I am not totally sure why, it may even be a compiler problem. But the error occurred during capture of care objects in raja loops.

Copy link
Member

@adayton1 adayton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adayton1
Copy link
Member

Was this the only change needed for the offsite builds? I thought that =default was supposed to create both host and device default versions. I'm surprised that these are the only ones...

@liu15 Yes, this only happened on offsite builds. I am not totally sure why, it may even be a compiler problem. But the error occurred during capture of care objects in raja loops.

= default is supposed to create both host and device versions of the constructor. But nvcc sometimes fails at generating the device version. The RAJA team has experienced this as well.

@adayton1 adayton1 changed the title fixes for offsite build Fixes for some nvcc versions Sep 13, 2024
@adayton1 adayton1 merged commit 893f3e3 into develop Sep 13, 2024
12 checks passed
@adayton1 adayton1 deleted the feature/taller1/gpuCOntructorFix branch September 13, 2024 19:59
adayton1 pushed a commit that referenced this pull request Oct 14, 2024
* Explicitly define default and copy constructor for the portable specialization of host_device_map
@dtaller dtaller mentioned this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants