Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests in CI #302

Closed
wants to merge 4 commits into from
Closed

Conversation

adrienbernede
Copy link
Member

Test were turned OFF in CI !

@adrienbernede
Copy link
Member Author

adrienbernede commented Nov 14, 2024

@adayton1 Could you please have a look at the test build failure ?
https://lc.llnl.gov/gitlab/care/CARE/-/jobs/2241570
https://lc.llnl.gov/gitlab/care/CARE/-/jobs/2241506

@adayton1
Copy link
Member

@adayton1 Could you please have a look at the test build failure ? https://lc.llnl.gov/gitlab/care/CARE/-/jobs/2241570 https://lc.llnl.gov/gitlab/care/CARE/-/jobs/2241506

I will take a look.

@adayton1
Copy link
Member

@adayton1 Could you please have a look at the test build failure ? https://lc.llnl.gov/gitlab/care/CARE/-/jobs/2241570 https://lc.llnl.gov/gitlab/care/CARE/-/jobs/2241506

I will take a look.

Does this fix the issue? https://github.com/LLNL/CARE/pull/304/files

@adayton1
Copy link
Member

Some of the failures occur because CARE now requires c++17, but I haven't updated that in the CI or added checks in the build system for it yet.

@adrienbernede
Copy link
Member Author

adrienbernede commented Nov 19, 2024

@adayton1,
I added what seemed necessary at the Spack level, which should reflect in the CMakeCache file.
However, I did not add the CMake checks (yet).
Still, it looks like there are new compilers errors to deal with. See:

  • Rocm builds on corona and tioga.
  • Clang and gcc builds on lassen.
    When the build succeeds, the tests fail consistently with messages in the like of:
Umpire runtime_error [/dev/shm/poodle2-2124085/spack-user-cache/stage/dayton8/spack-stage-umpire-2024.07.0-qwjhyvjz2pyax27gj4s7yoec2jvajimx/spack-src/src/umpire/ResourceManager.cpp:246]: Allocator 540620898 not found. Available allocators: [HOST,2]

@adrienbernede adrienbernede deleted the woptim/enable-tests-in-ci branch November 26, 2024 10:56
@adrienbernede adrienbernede restored the woptim/enable-tests-in-ci branch November 26, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants