-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Variorum Service to use Energy API. #579
Draft
tpatki
wants to merge
18
commits into
LLNL:master
Choose a base branch
from
tpatki:fixes_to_tre_caliper_port
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpatki
force-pushed
the
fixes_to_tre_caliper_port
branch
from
August 2, 2024 01:31
e13c1d0
to
06ee911
Compare
Note: Once LLNL/variorum#575 is addressed, we will update the Caliper service to support nested regions in a separate PR. |
@daboehme This is ready for your review. Please let me know if I missed something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes LLNL/variorum#572.
Problem:
The existing Variorum service in Caliper uses the
variorum_get_power_json
API, which only returns instantaneous power. This is not meaningful when we are looking at function start/end.Solution:
What we'd like instead is total energy for the function. With Variorum v0.8, we have added the
variorum_get_energy_json
API. This PR updates the existing service to use this newly added API.This PR supersedes #567 from @tjeter.
Limitations and future work:
This version of the service will not support nested regions in Caliper. Once LLNL/variorum#575 is addressed, we will update the Caliper service to support nested regions in a separate PR.
Testing:
This PR as been tested with multiple caliper examples (
examples/apps/c-spinloop-example
) by @rountree and @tpatki on Lassen. This new spinloop example has also been added to the PR.ToDo:
m.delta_attr
.Co-authored by @tjeter.