Fix function signatures for IndexSet builders #411
Conversation
| @@ -81,7 +81,8 @@ void buildTypedIndexSetAligned(IndexSet& hiset, | |||
| * | |||
| ****************************************************************************** | |||
| */ | |||
| void buildLockFreeBlockIndexset(IndexSet& iset, | |||
| void buildLockFreeBlockIndexset(RAJA::TypedIndexSet<RAJA::RangeSegment, | |||
There was a problem hiding this comment.
This one uses RangeSegments only. Please remove other segment types.
There was a problem hiding this comment.
Rather than deal with these changes here, shall I move the indexsetbuilders into LULESH?
There was a problem hiding this comment.
No. They need work, but I believe folks are using them.
There was a problem hiding this comment.
Changing them to use strongly-typed IndexSets with a subset of segment types will break for existing users.
There was a problem hiding this comment.
Good point. Leave them as is for now. I don't think there is any additional overhead for not using segment types.
| @@ -97,7 +98,8 @@ void buildLockFreeBlockIndexset(IndexSet& iset, | |||
| * | |||
| ****************************************************************************** | |||
| */ | |||
| void buildLockFreeColorIndexset(IndexSet& iset, | |||
| void buildLockFreeColorIndexset( RAJA::TypedIndexSet<RAJA::RangeSegment, | |||
There was a problem hiding this comment.
This one uses RangeSegment and List Segment only. Please remove stride segment type.
There was a problem hiding this comment.
That won't fix the bug, because LULESH is still using IndexSet.
There was a problem hiding this comment.
I know. We should change the type in lulesh. It should be easy because I think it is using a macro or typedef.
These were missed when TypedIndexSet was created.