Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ma57 parameter fix #645

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Ma57 parameter fix #645

wants to merge 3 commits into from

Conversation

nychiang
Copy link
Collaborator

@nychiang nychiang commented Jul 25, 2023

This PR changes some parameter settings in Ma57:

  1. Set icntl[9] to 1 --- default number of iterative refinement to 1. Right now we initialize it as 10 and replace it to 1 before using it.
  2. allocate more spaces to some work arrary, if icntl[9] > 1 (required by ma57)
  3. allow the combination of icntl[9]>1 and job = 0 or job=2 (but user needs to modify the source code to test these features --- per @pelesh request)

@pelesh @cnpetra

@nychiang nychiang requested review from cnpetra and pelesh July 25, 2023 19:53
@pelesh
Copy link
Collaborator

pelesh commented Jul 27, 2023

I ran some tests with large ACOPF models with MA57 in this branch and convergence was much worse than when run with develop branch. I ran it as is without any changes to MA57 parameters. This is my hiop.options file:

KKTLinsys xdycyd
print_options yes

verbosity_level 3
tolerance 1e-6
#fixed_var relax

duals_init zero
fact_acceptor inertia_free

compute_mode cpu
linear_solver_sparse ma57

@nychiang
Copy link
Collaborator Author

@pelesh did you use the same option file in develop branch? I didn't change any setting in this PR (see the change log). I tried the latest develop branch with your option file, and all the unit tests work fine.

@pelesh
Copy link
Collaborator

pelesh commented Aug 11, 2023

@pelesh did you use the same option file in develop branch? I didn't change any setting in this PR (see the change log). I tried the latest develop branch with your option file, and all the unit tests work fine.

I need to do some more testing. Preliminary tests did not work out of the box.

@nychiang
Copy link
Collaborator Author

@pelesh have you tried the changes in this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants