Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spack v1.0 support: %foo +bar -> +bar %foo #714

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

spack v1.0 support: %foo +bar -> +bar %foo #714

wants to merge 1 commit into from

Conversation

haampie
Copy link

@haampie haampie commented Mar 17, 2025

Spack v1.0 will parse pkg %gcc +foo as "pkg with direct dependency gcc
with variant foo enabled" instead of "pkg with variant foo enabled and compiler
gcc". Reorder as pkg +foo %gcc to be compatible with Spack v0.x and
v1.0.

@haampie
spack v1.0 support: %foo +bar -> +bar %foo
cd5d21b 
Spack v1.0 will parse `pkg %gcc +foo` as "pkg with direct dependency gcc
with variant foo enabled" instead of "pkg with variant foo enabled and compiler
gcc". Reorder as `pkg +foo %gcc` to be compatible with Spack v0.x and
v1.0.
@cnpetra cnpetra requested review from nychiang and cnpetra March 17, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnpetra cnpetra cnpetra approved these changes

@nychiang nychiang nychiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haampie @cnpetra @nychiang