Addition of Python function call 'scrape' #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from another Python script and returning the JSON output
IanLee1521
reviewed
Oct 4, 2022
There was a problem hiding this comment.
@stuchalk - this looks good overall.. Do you think this would be good to adapt the main script to use this method as well? Just for consistency?
Comment on lines
+25
to
+26
| f = open(configfile) | ||
| config_json = json.load(f) |
There was a problem hiding this comment.
Suggested change
| f = open(configfile) | |
| config_json = json.load(f) | |
| with open(configfile) as fp: | |
| config_json = json.load(fp) |
| # process | ||
| code_json = code_gov.process_config(config_json) | ||
| code_gov.force_attributes(code_json, config_json) | ||
| logger.info("Number of Projects: %s", len(code_json["releases"])) |
There was a problem hiding this comment.
I wonder if this logger call should move in to code_gov.process_config(...) so that the message happens at the time the objects are parsed? Thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of Python a bare bones function call 'scrape' (functions.py file) for processing config file from another Python script and returning the JSON output.