Skip to content

Conversation

@IanLee1521 IanLee1521 self-assigned this Apr 17, 2025
@IanLee1521
Copy link
Collaborator Author

fyi to @LRWeber about this change.

Copy link
Member

@LRWeber LRWeber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may also want to delete requirements.txt since it references the other deleted file.

@LRWeber
Copy link
Member

LRWeber commented Apr 17, 2025

Our automated testing action currently has the dev dependencies hardcoded.

pip install bandit black isort flake8
pip install .
npm install -g markdownlint-cli@0.33.0
make test

Should it be using a different command to leverage the dependency list(s) in the .toml file (e.g. pip install .[dev])? Or is it specifically using a minimal list? (And if that's the case, should that be another list defined in the .toml file?)

@IanLee1521
Copy link
Collaborator Author

@LRWeber - good catches! I just updated the actions file to convert over to using the definition out of the pyproject.toml file instead. Good catch!

@IanLee1521 IanLee1521 requested a review from LRWeber April 20, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants