ASA core modules #641
ASA core modules #641
Conversation
src/sunadjointcheckpointscheme/fixed/sunadjointcheckpointscheme_fixed.c
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| SUNCheckCall(SUNDataNode_HasChildren(step_data_node, &has_children)); | ||
| if (!has_children) |
There was a problem hiding this comment.
Couldn't this be
| } | |
| SUNCheckCall(SUNDataNode_HasChildren(step_data_node, &has_children)); | |
| if (!has_children) | |
| } | |
| else |
There was a problem hiding this comment.
Im not sure which line this is referring to.
src/sunadjointcheckpointscheme/fixed/sunadjointcheckpointscheme_fixed.c
Outdated
Show resolved
Hide resolved
|
|
||
| if (!(step_num % IMPL_MEMBER(self, interval))) | ||
| { | ||
| if (stage_num == 0) { *yes_or_no = SUNTRUE; } |
There was a problem hiding this comment.
This will be z[0] rather than y_n for methods with an implicit first stage.
| return SUN_ERR_CHECKPOINT_NOT_FOUND; | ||
| } | ||
|
|
||
| SUNCheckCall(SUNDataNode_GetDataNvector(solution_node, *yout, t)); |
There was a problem hiding this comment.
Since this functions takes an N_Vector why is the input to this function N_Vector*?
There was a problem hiding this comment.
I do not understand this comment.
| { | ||
| SUNFunctionBegin(self->sunctx); | ||
|
|
||
| void* queue = NULL; |
There was a problem hiding this comment.
Here and below, I think a NULL queue will cause an error with SYCL
| SUNMemoryType buffer_mem_type = N_VGetDeviceArrayPointer(v) ? SUNMEMTYPE_DEVICE | ||
| : SUNMEMTYPE_HOST; |
There was a problem hiding this comment.
Here and below, user supplied vectors my not supply N_VGetDeviceArrayPointer but still use device data. I think we'll need a new NVector function to query what memory space the data is stored in.
|
|
||
| void* queue = NULL; | ||
|
|
||
| SUNMemoryType leaf_mem_type = SUNMEMTYPE_HOST; |
There was a problem hiding this comment.
Should this be leaf_data->type?
| if (leaf_mem_type == buffer_mem_type) | ||
| { | ||
| sunrealtype* data_ptr = leaf_data->ptr; | ||
| *t = data_ptr[0]; |
There was a problem hiding this comment.
Here and below, can we assume data_ptr is host data or should this use the memory helper copy?
| if (leaf_mem_type == buffer_mem_type) | ||
| { | ||
| sunrealtype* data_ptr = leaf_data->ptr; | ||
| data_ptr[0] = t; |
There was a problem hiding this comment.
Here and below, can we assume data_prtr is host data or does this need to use the memory helper copy?
| return SUN_SUCCESS; | ||
| } | ||
|
|
||
| SUNErrCode SUNAdjointStepper_ReInit(SUNAdjointStepper self, N_Vector y0, |
There was a problem hiding this comment.
[discussion] The current behavior is like ReInit, but we do not have a SUNStepperReInit function. So the user would need to reinitialize the forward and adjoint steppers. We could add SUNStepperReInit with the same signature of SUNStepperReset. This would require some updates to the ARKODE ReInit functions that would be wrapped by a generic ReInit to allow for NULL inputs in order to retain the current RHS functions (and some other changes handle NULL inputs).
|
|
||
| while ((direction == -one && t > tout) || (direction == one && t < tout)) | ||
| { | ||
| SUNCheckCall(SUNAdjointStepper_OneStep(self, tout, sens, tret)); |
There was a problem hiding this comment.
To get interpolated output at the desired time this should use SUNStepper_Evolve (or we'll need to add a SUNStepper function to get interpolated output)
|
|
||
| SUNErrCode retcode = SUN_SUCCESS; | ||
| sunrealtype t = self->tf; | ||
| SUNCheckCall(SUNStepper_OneStep(adj_sunstepper, tout, sens, &t)); |
There was a problem hiding this comment.
Is managing integrating to and loading checkpoints handled inside the SUNStepper wrapper? With the addition of SUNStepper_ResetCheckpointIndex I would have expected to see that in the SUNAdjointStepper functions for Evolve and OneStep.
| self->last_flag = adj_sunstepper->last_flag; | ||
|
|
||
| self->step_idx--; | ||
| self->nst++; |
There was a problem hiding this comment.
Do we need to store nst or can we get this from the adj_sunstepper?
There was a problem hiding this comment.
Check SUNStlVector_* return codes?
| int retval; | ||
| int64_t idx; | ||
| int64_t retval; | ||
| sunbooleantype collision; | ||
|
|
||
| if (map == NULL || key == NULL || value == NULL) { return (-1); } |
There was a problem hiding this comment.
| if (map == NULL || key == NULL || value == NULL) { return (-1); } | |
| if (map == NULL || key == NULL || value == NULL) { return SUNHASHMAP_ERROR; } |
| /* Extract the elapsed times from the hash map */ | ||
| SUNHashMap_Values(p->map, (void***)&values, sizeof(sunTimerStruct)); | ||
| sunTimerStruct* reduced = | ||
| (sunTimerStruct*)malloc(p->map->size * sizeof(sunTimerStruct)); | ||
| for (i = 0; i < p->map->size; ++i) { reduced[i] = *values[i]; } | ||
| (sunTimerStruct*)malloc(map_size * sizeof(sunTimerStruct)); |
| @@ -507,7 +527,7 @@ SUNErrCode sunCollectTimers(SUNProfiler p) | |||
| MPI_Op_free(&MPI_sunTimerStruct_MAXANDSUM); | |||
|
|
|||
| /* Update the values that are in this rank's hash map. */ | |||
| for (i = 0; i < p->map->size; ++i) | |||
| for (int64_t i = 0; i < map_size; ++i) | |||
There was a problem hiding this comment.
| for (int64_t i = 0; i < map_size; ++i) | |
| for (int i = 0; i < map_size; ++i) |
| @@ -320,23 +449,37 @@ SUNErrCode SUNHashMap_Sort(SUNHashMap map, SUNHashMapKeyValue** sorted, | |||
| **Returns:** | |||
| * A SUNErrCode indicating success or a failure | |||
| */ | |||
| #if SUNDIALS_MPI_ENABLED | |||
There was a problem hiding this comment.
I think this was needed to avoid an unused function warning because this is only called when MPI is enabled (or at least it was before)
Co-authored-by: David Gardner <gardner48@llnl.gov>
… into feature/sunadjoint-core-modules
This PR adds the core modules that will support adjoint sensitivity analysis in a package-agnostic way.