Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed a typo in README and in a function input argument #661

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

maggul
Copy link
Collaborator

@maggul maggul commented Feb 5, 2025

Fixed a typo in README and in a function input argument

README.md Outdated
@@ -19,7 +19,7 @@ nonlinear algebraic systems:

* ARKODE - for integrating stiff, nonstiff, and multirate ODEs of the form

$$M(t) \\, y' = f_1(t,y) + f_2(t,y), \quad y(t_0) = y_0$$
$$M(t) \, y' = f_1(t,y) + f_2(t,y), \quad y(t_0) = y_0$$
Copy link
Member

@balos1 balos1 Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not want the comma (see how it renders). I dont think we really need a space between M(t) and y' either so I recommend removing the backslashes completely.

Suggested change
$$M(t) \, y' = f_1(t,y) + f_2(t,y), \quad y(t_0) = y_0$$
$$M(t)y' = f_1(t,y) + f_2(t,y), \quad y(t_0) = y_0$$

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to render differently on different systems. In the codespace of github, my change was doing what we really mean without comma. I will remove those as well to make sure it will render correctly on the one you pointed.

@gardner48 gardner48 merged commit b0cb581 into develop Feb 6, 2025
46 checks passed
@gardner48 gardner48 deleted the quick_fixes branch February 6, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants