Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call squash in groupby #219

Merged
merged 3 commits into from
Nov 2, 2024
Merged

Call squash in groupby #219

merged 3 commits into from
Nov 2, 2024

Conversation

michaelmckinsey1
Copy link
Collaborator

Add a conditional check to groupby for calling squash to update the graph, if nodes disappear from the performance data. This is necessary sometimes for Thickets where fill_perfdata=False, as the groupby splits up the profiles into different Thickets, which may contain different nodes. We do the same check in filter_metadata and filter_profile.

@michaelmckinsey1 michaelmckinsey1 added area-thicket Issues and PRs involving Thicket's core Thicket datastructure and associated classes priority-normal Normal priority issues and PRs type-bug Identifies bugs in issues and identifies bug fixes in PRs labels Oct 31, 2024
@michaelmckinsey1 michaelmckinsey1 mentioned this pull request Oct 31, 2024
Merged
9 tasks
@dyokelson dyokelson self-requested a review November 1, 2024 21:40
dyokelson
dyokelson approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@dyokelson dyokelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slabasan slabasan merged commit b66949a into LLNL:develop Nov 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyokelson dyokelson dyokelson approved these changes

@slabasan slabasan slabasan approved these changes

Assignees
No one assigned
Labels
area-thicket Issues and PRs involving Thicket's core Thicket datastructure and associated classes priority-normal Normal priority issues and PRs type-bug Identifies bugs in issues and identifies bug fixes in PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelmckinsey1 @slabasan @dyokelson