Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Test for node_ordering Setting #236

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Unit Test for node_ordering Setting #236

wants to merge 1 commit into from

Conversation

michaelmckinsey1
Copy link
Collaborator

It was discovered from hatchet#154, that node_ordering was being set to False, after calling Graph.union() which happens in Ensemble.unify()

@michaelmckinsey1 michaelmckinsey1 added area-tests Issues and PRs involving Thicket's automated tests priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-bug Identifies bugs in issues and identifies bug fixes in PRs labels Jan 22, 2025
@michaelmckinsey1 michaelmckinsey1 self-assigned this Jan 22, 2025
@michaelmckinsey1 michaelmckinsey1 mentioned this pull request Jan 23, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slabasan slabasan Awaiting requested review from slabasan

At least 1 approving review is required to merge this pull request.

Assignees

@michaelmckinsey1 michaelmckinsey1

Labels
area-tests Issues and PRs involving Thicket's automated tests priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-bug Identifies bugs in issues and identifies bug fixes in PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@michaelmckinsey1