-
Notifications
You must be signed in to change notification settings - Fork 3
Added Offset example and tweaked times #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nabobalis
wants to merge
1
commit into
main
Choose a base branch
from
offset
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's GuideRefactors IRIS time metadata usage from STARTOBS/ENDOBS to DATE_OBS and explicit per-frame times, expands spectral band mappings, updates string representations and wobble timestamp logic, adds an example demonstrating SJI–SG WCS offsets, and refreshes tooling configs (tox, Ruff). Sequence diagram for updated per-frame WCS time handling in _create_wcssequenceDiagram
participant User
participant read_spectrograph_lvl2
participant _create_wcs
participant FITS_HDUList as FITS_HDUList
participant AstropyTime as Time
participant SunPyCoord as get_body_heliographic_stonyhurst
User->>read_spectrograph_lvl2: open spectrograph FITS
read_spectrograph_lvl2->>FITS_HDUList: load primary and extension headers
read_spectrograph_lvl2->>_create_wcs: call with hdulist
_create_wcs->>AstropyTime: base_time = Time(hdulist[0].header[STARTOBS])
_create_wcs->>FITS_HDUList: read per-frame TIME column
_create_wcs->>AstropyTime: obs_times = base_time + time_column * s
loop for each frame i
_create_wcs->>SunPyCoord: get_body_heliographic_stonyhurst(Earth, obs_times[i].isot)
SunPyCoord-->>_create_wcs: Earth heliographic location at obs_times[i]
_create_wcs->>_create_wcs: build Helioprojective observer with obstime = obs_times[i]
_create_wcs->>_create_wcs: compute rotation_matrix and FITS WCS for frame i
end
_create_wcs-->>read_spectrograph_lvl2: list of per-frame WCS objects
read_spectrograph_lvl2-->>User: SpectrogramCube with accurate per-frame WCS times
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Align IRIS SJI/SG timing with DATE_OBS metadata, expand wavelength band mappings, and add an example demonstrating potential SJI–spectrograph WCS offsets.
New Features:
Bug Fixes:
Enhancements:
Build:
CI:
Documentation: