-
Notifications
You must be signed in to change notification settings - Fork 0
[CHROE] main 병합 및 배포 #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[CHROE] main 병합 및 배포 #167
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a55873a
refactor: AppleRestClient Bean 등록 및 변수명 변경
chltjsdl0119 dded26f
feat: DTO 메시지 및 스키마 추가
chltjsdl0119 5906b43
refactor: 미사용 설정 클래스 삭제
chltjsdl0119 ddf8cc2
feat: HealthCheckController 추가
chltjsdl0119 768ce5f
Merge pull request #165 from LOOP-ON/feature/164-refactor-auth
chltjsdl0119 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
src/main/java/com/loopon/auth/application/dto/response/AuthResult.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 0 additions & 7 deletions
7
src/main/java/com/loopon/global/config/HttpInterfaceConfig.java
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
src/main/java/com/loopon/global/health/HealthCheckController.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| package com.loopon.global.health; | ||
|
|
||
| import com.loopon.global.domain.dto.CommonResponse; | ||
| import io.swagger.v3.oas.annotations.Hidden; | ||
| import lombok.RequiredArgsConstructor; | ||
| import org.springframework.beans.factory.annotation.Value; | ||
| import org.springframework.http.ResponseEntity; | ||
| import org.springframework.web.bind.annotation.GetMapping; | ||
| import org.springframework.web.bind.annotation.RestController; | ||
|
|
||
| import java.time.LocalDateTime; | ||
| import java.util.Map; | ||
|
|
||
| @RestController | ||
| @Hidden | ||
| @RequiredArgsConstructor | ||
| public class HealthCheckController { | ||
|
|
||
| @Value("${spring.profiles.active:default}") | ||
| private String activeProfile; | ||
|
|
||
| @GetMapping("/") | ||
| public ResponseEntity<CommonResponse<Map<String, String>>> systemStatus() { | ||
| Map<String, String> status = Map.of( | ||
| "status", "UP", | ||
| "profile", activeProfile, | ||
| "serverTime", LocalDateTime.now().toString(), | ||
| "message", "LoopOn API Server is running!" | ||
| ); | ||
|
Comment on lines
+19
to
+29
|
||
|
|
||
| return ResponseEntity.ok(CommonResponse.onSuccess(status)); | ||
| } | ||
|
|
||
| @GetMapping("/health") | ||
| public String healthCheck() { | ||
| return "OK"; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RestClient에 이미 baseUrl("https://appleid.apple.com")을 설정했는데, 요청에서 다시 절대 URL("https://appleid.apple.com/auth/token")을 사용하고 있습니다. baseUrl과 URI가 분리되면 향후 호스트 변경/환경 분기 시 한쪽만 수정되어 오류가 날 수 있으니, 상대 경로(예: "/auth/token")로 호출해 baseUrl 설정을 일관되게 활용하는 편이 안전합니다.