Converted pre-existing C++ integration tests to use wrapper macros, added to separate integration executable, and set to run again #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n mip.integration test function with wrappers
…acketView function to use wrappers
…conventions are decided
…ail intentionally for testing
…al failing integration test for testing
…ional failing tests
…immediately upon abort
microstrain-sam
approved these changes
Oct 9, 2025
rafarrel
force-pushed
the
feature/add_integration_tests
branch
from
f15dc6a to
1323ada
Compare
robbiefish
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have a defined practice for integration testing yet (this will be developed shortly, there's a whole section of the book dedicated to it). But the restrictions are much more flexible than unit testing so these are good enough for now. This is part of a broader initiative to get all the old tests working again.
@microstrain-sam I disabled the packet interface tests again and marked the broken tests with TODO comments. Those can be fixed later after the naming conventions are determined. Some of them are working but failing, so it might be worth investigating those to make sure they aren't indicative of a larger issue. There are also a couple of tests that exhibit domain leakage, which I also marked with TODO comments. If there's an easy fix for those, we can add them as part of this PR. But we may need to wait until the tests are restructured for those.
@robbiefish @dacuster I added you guys to this review for the Jenkins changes, but feel free to look at the tests as well.