Skip to content

Comments

Fix for issue #114: Added support for device HmIP-SWO-B#150

Open
Baumus wants to merge 14 commits intoLRuesink-WebArray:masterfrom
Baumus:issue-114-HmIP-SWO-B-support
Open

Fix for issue #114: Added support for device HmIP-SWO-B#150
Baumus wants to merge 14 commits intoLRuesink-WebArray:masterfrom
Baumus:issue-114-HmIP-SWO-B-support

Conversation

@Baumus
Copy link

@Baumus Baumus commented May 16, 2024

Added support for device HmIP-SWO-B

@Baumus
Copy link
Author

Baumus commented Jun 26, 2024

I fixed a couple of issues in the code in order to get the app working properly and avoid crashes from time to time. Please add support for device HmIP-SWO-B and feel free to integrate the other changes I made in order to provide a better experience.

@LRuesink-WebArray
Copy link
Owner

Hi! Thanks for the contribution!
Would it be possible to split the changes (adding the device, refactoring, fixing the crashes, etc.)?
Right now it's hard to review and see the impact of the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants