Correct sky_pos and local_wcs in photon op tests #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cs and image_pos. This changes expected values in the regression tests.
rmjarvis
approved these changes
Dec 26, 2024
tests/test_photon_ops.py
Outdated
Comment on lines
649
to
655
| }, | ||
| ] | ||
| }, | ||
| "sky_pos": create_test_img_wcs( | ||
| boresight=galsim.CelestialCoord(1.1047934165124105 * galsim.radians, -0.5261230452954583 * galsim.radians), | ||
| rottelpos=np.pi / 3 * galsim.radians | ||
| ).toWorld(image_pos), |
There was a problem hiding this comment.
Slightly cleaner here would be to define boresight once outside the config, and then use both "boresight": boresight above in photon_ops and use that same value here for the boresight parameter. Otherwise there are two places where a bunch of random numbers need to be visually confirmed to match up.
There was a problem hiding this comment.
Thanks Mike, nice spot! I've made that change now.
…t_config_rubin_optics.
|
Merging as agreed at yesterday's meeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the photon op tests appear not to be self-consistent: the
sky_posandlocal_wcsare set independently though both should actually be derived from the image's WCS and the object position within it. This wouldn't be an issue except that the incoming PR #424 implements a newXyToVwhich is self-consistent through use of theimg_wcsalone and so breaks the regression tests here. This PR updates the tests to calculate the thesky_posandlocal_wcstogether from theimage_posandimg_wcs.Note this isn't an issue in the photon ops themselves, just in the test method. This also changes the expected photon position centre in the regression tests from (-564.5, -1431.4) to (-960.28, -308.09). This is borne out in the tests in PR #424 using the new
XyToVimplementation which preserves these results.