Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VHDX LogEntry.TryRead() Bug Fix and Improvements #5

Merged
merged 1 commit into from
Mar 1, 2024
Merged

VHDX LogEntry.TryRead() Bug Fix and Improvements #5

merged 1 commit into from
Mar 1, 2024

Commits on Mar 1, 2024

  1. VHDX LogEntry.TryRead() Bug Fix and Improvements 

    Change LogEntryHeader member variables to properties.
Read header into 64-byte, stackalloc'd buffer, then read remaining bytes directly into logEntryBuffer.
Remove buggy byte availability calculation.
Remove redundant signature check (which is done in LogEntryHeader.IsValid).
Use ReadMaximum instread of ReadExactly to guarantee no exception will be thrown, and use its return value to verify correct byte count.
    @glenebob
    glenebob committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    b0ecacc View commit details
    Browse the repository at this point in the history