✨ **Implement CanvasController init() - buffer and changes #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Implement getCanvasImage - json response
TuberculeP
reviewed
Feb 24, 2024
backend/controllers/Canvas.ts
Outdated
| * * Log the canvas initialization | ||
| */ | ||
| } | ||
| // TODO: Log the canvas initialization |
Code-Nam
added
pending-review
Kan-A-Pesh
requested review from
Kan-A-Pesh
and removed request for
TuberculeP
Kan-A-Pesh
requested changes
Feb 26, 2024
| @@ -3,34 +3,45 @@ import type PlacePixelPayload from "common/requests/PlacePixel"; | |||
| import type express from "express"; | |||
| import type SocketIO from "socket.io"; | |||
|
|
|||
| import getRedisClient from "../database/redis"; | |||
|
|
|||
| class CanvasController { | |||
| private static canvas: Canvas; | |||
|
|
||
| // TODO: Log the canvas initialization (waiting merge) | ||
| console.log("Canvas not found in the database, creating a new one"); | ||
| await getRedisClient.set("canvas", JSON.stringify(this.canvas)); |
There was a problem hiding this comment.
buffer dans une entrée
metadonnées dans une autres entrée
| * * Log the canvas initialization | ||
| */ | ||
| } | ||
| const canvasBuffer = await getRedisClient.get("canvas"); |
There was a problem hiding this comment.
??? tu récupères tout le canvas ou juste le buffer ducoup ?
| await getRedisClient.set("canvas", JSON.stringify(this.canvas)); | ||
| } else { | ||
| console.log("Canvas found in the database, loading it"); | ||
| this.canvas = JSON.parse(canvasBuffer); |
| // TODO: Send the canvas image as a response | ||
| res.send(this.canvas); |
There was a problem hiding this comment.
getCanvasImage doit renvoyer une image, ou du moins un buffer avec les données du buffer, d'autant que si il ne renvoie pas une image directement il doit être capable de réenvoyer des métadonnées comme la taille height et width pour être capable sur le frontend de parser ces données
Kan-A-Pesh
added
in-correction
and removed
pending-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**Implement getCanvasImage - json response