Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ADD login page #9

Merged
merged 3 commits into from
Feb 15, 2024
Merged

✨ADD login page #9

merged 3 commits into from
Feb 15, 2024

Conversation

Wolap
Copy link
Collaborator

@Wolap Wolap commented Feb 15, 2024

No description provided.

@Wolap Wolap added the pending-review Lorsque vous envoyez votre PR, ajoutez ce label pour vérification. label Feb 15, 2024
@Wolap Wolap requested a review from Kan-A-Pesh February 15, 2024 16:57
@Kan-A-Pesh Kan-A-Pesh changed the base branch from main to dev February 15, 2024 17:08
@Kan-A-Pesh Kan-A-Pesh changed the title Features/login ✨ADD login page Feb 15, 2024
Kan-A-Pesh
Kan-A-Pesh requested changes Feb 15, 2024
View reviewed changes
Copy link
Member

@Kan-A-Pesh Kan-A-Pesh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move login-specific styles to another file (e.g. src/styles/login.module.css)

Kan-A-Pesh
Kan-A-Pesh requested changes Feb 15, 2024
View reviewed changes
Copy link
Member

@Kan-A-Pesh Kan-A-Pesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import 'styles/login.css' in the pages/login.tsx file instead of the App.tsx file

@Kan-A-Pesh Kan-A-Pesh removed the pending-review Lorsque vous envoyez votre PR, ajoutez ce label pour vérification. label Feb 15, 2024
@Kan-A-Pesh Kan-A-Pesh merged commit 7c8a70a into dev Feb 15, 2024
1 check passed
@Kan-A-Pesh Kan-A-Pesh deleted the features/login branch February 17, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kan-A-Pesh Kan-A-Pesh Kan-A-Pesh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wolap @Kan-A-Pesh