Feedback #23
Open
Feedback #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Se crearon tres historias de usuario que se desarrollaron a través de tres sprints: El usuario podrá desplegar y escoger a través de un <select>, la lista de países y el indicador deseado. Se desplegará la información de los años y porcentaje en una tabla HTML. El usuario podrá seleccionar un país, un indicador y distintos años a través de ventanas modales. Posteriormente se desplegará la información sólo de los años elegidos en una tabla HTML. El usuario podrá seleccionar un país, un indicador y distintos años a través de ventanas modales. Además podrá elegir entre desplegar la información en una tabla o gráfica.
HectorBlisS
suggested changes
Mar 25, 2020
| console.log(indicator) | ||
| } | ||
|
|
||
| function loadYears (list) { |
There was a problem hiding this comment.
Bien por el nombre de las funciones en ingles
Comment on lines
+84
to
+98
| /*function setYearOptions(list) { | ||
| list.forEach(i=>{ | ||
| let option = document.createElement('option') | ||
| option.value = i | ||
| option.label = i | ||
| yearSelect.appendChild(option) | ||
| }) | ||
| } | ||
|
|
||
| function yearOnChange(e){ | ||
| let value = e.target.value | ||
| year = value | ||
| console.log(year) | ||
| } | ||
| */ |
There was a problem hiding this comment.
Evitar dejar código comentado, mejor eliminar
| }) | ||
|
|
||
| function openModal(modal){ | ||
| if(modal==null) return |
There was a problem hiding this comment.
if(!modal) esto equivale a decir: if(modal===null || modal===undefined) y es mejor ;)
| test.addEventListener('click', onChange) | ||
| indiSelect.addEventListener('change', indiOnChange) | ||
| overlay.addEventListener('click', ()=>{ | ||
| const modals = document.querySelectorAll('.modal.active') |
There was a problem hiding this comment.
Bien por el uso de qurySelector
| overlay.addEventListener('click', ()=>{ | ||
| const modals = document.querySelectorAll('.modal.active') | ||
| modals.forEach(modal=>{ | ||
| closeModal(modal) |
There was a problem hiding this comment.
Bien por el uso de una función para no repetir código
| display: none; | ||
| } | ||
|
|
||
| label{ |
There was a problem hiding this comment.
Evitemos editar etiquetas, preferible clases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.