Solicitando primer pull request #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HectorBlisS
suggested changes
Mar 25, 2020
src/index.html
Outdated
Comment on lines
20
to
34
| <option id="grass">grass</option> | ||
| <option id= "poison">poison</option> | ||
| <option id= "fire">fire</option> | ||
| <option id = "fairy">fairy</option> | ||
| <option id= "water">water</option> | ||
| <option id = "bug">bug</option> | ||
| <option id = "normal">normal</option> | ||
| <option id = "electric">electric</option> | ||
| <option id = "ground">ground</option> | ||
| <option id = "fighting">fighting</option> | ||
| <option id = "psychic">psychic</option> | ||
| <option id = "rock">rock</option> | ||
| <option id = "ice">ice</option> | ||
| <option id = "ghost">ghost</option> | ||
| <option id = "dragon">dragon</option> |
There was a problem hiding this comment.
Esto pudo crearse dinámicamente con la misma data de los pokemons.
src/main.js
Outdated
| @@ -9,7 +9,7 @@ let closeModal = document.querySelectorAll(".close"); | |||
| const images = dataPokemon.forEach((item) => { | |||
| let image= item.img; | |||
| let label= document.createElement('img'); | |||
| label.className+=("a" +item.id) | |||
| label.id= ("a"+item.type) | |||
| let btn= document.createElement('button'); | |||
| btn.className+= ("btn-Images") | |||
There was a problem hiding this comment.
className no existe en native, eso es de ReactJS, la forma de trabajar con clases en Vanilla es:
btn.classList.add("btn-Images")
src/main.js
Outdated
| @@ -9,7 +9,7 @@ let closeModal = document.querySelectorAll(".close"); | |||
| const images = dataPokemon.forEach((item) => { | |||
| let image= item.img; | |||
| let label= document.createElement('img'); | |||
| label.className+=("a" +item.id) | |||
| label.id= ("a"+item.type) | |||
| let btn= document.createElement('button'); | |||
| btn.className+= ("btn-Images") | |||
There was a problem hiding this comment.
Eviten usar clases con mayusculas o camelCase, btn-images
src/main.js
Outdated
| @@ -21,7 +21,7 @@ const images = dataPokemon.forEach((item) => { | |||
| //Modal Información Pokemon | |||
|
|
|||
| let btnImg = document.querySelectorAll('.btn-Images'); | |||
| let Imgs = btnImg.id | |||
| let Imgs = document.querySelector('#a') | |||
There was a problem hiding this comment.
Eviten las mayusculas en las variables, a menos que se entienda qué es una clase (JS) y porqué se usan Mayusculas en una declaración de clase, bien por el uso de querySelector
src/main.js
Outdated
Comment on lines
54
to
57
| function onChange(e){ | ||
| let value = e.target.value | ||
| let nuevaListaFiltrada = dataPokemon.filter(p=>p.type.includes(value)) | ||
| console.log(nuevaListaFiltrada) |
There was a problem hiding this comment.
Evitar español, y cuidado con la identación de las funciones, lo vuelve difícil de leer
src/index.html
Outdated
Comment on lines
19
to
22
| <a href="#">FUEGO</a> | ||
| <a href="#">FUEGO</a> | ||
| <a href="#">FUEGO</a> | ||
| <a href="#">FUEGO</a> |
src/data.js
Outdated
Comment on lines
5
to
8
| export const dataPokemon= () => { | ||
| //data.pokemon.filter((item) => item.id === Number); | ||
| return data.pokemon; | ||
| }; |
There was a problem hiding this comment.
Función inecesaria no crees?
src/main.js
Outdated
| let options= document.querySelector(".dropdown-content"); | ||
| options.addEventListener('click',onChange) | ||
| function onChange(e){ | ||
| let value = e.target.value |
There was a problem hiding this comment.
Muy bien el uso del evento.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.