Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20.2 Port #16

Merged
merged 6 commits into from
Nov 11, 2023
Merged

1.20.2 Port #16

merged 6 commits into from
Nov 11, 2023

Conversation

MerchantPug
Copy link
Contributor

@MerchantPug MerchantPug commented Nov 10, 2023

Generally a port, but there are some changes that might be a little strange.

  1. We can get rid of the Juuxel Vineflower plugin, as it is now built into FLoom.
  2. Textured Widgets have been rewritten to not use mapped textures, hence why I separated the buttons. I'm unsure about the location of these textures, but they do have to be in the gui/sprites folder.
  3. Displaying entities in GUIs with a method has also been rewritten, so I had to adjust a few values (mostly copied from the Horse like how it was previously). Quilt Mappings aren't finished for this method either, so you might notice some oddities with parameter names.
  4. Updated fabric in dependencies to fabric-api.

@MerchantPug MerchantPug marked this pull request as ready for review November 10, 2023 15:40
Copy link
Owner

@LambdAurora LambdAurora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the PNG files have been optimized out (with optipng/trimage) so when I merge I don't save in history the unoptimized versions of those files. (if not done already)

@MerchantPug
Copy link
Contributor Author

MerchantPug commented Nov 10, 2023

Please make sure the PNG files have been optimized out (with optipng/trimage) so when I merge I don't save in history the unoptimized versions of those files. (if not done already)

I haven't done this already, I'll do so in a bit.

Thanks for reminding me.

@LambdAurora LambdAurora changed the base branch from 1.20 to 1.20.2 November 11, 2023 13:31
@LambdAurora LambdAurora merged commit d21c169 into LambdAurora:1.20.2 Nov 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants