Skip to content

Commit

Permalink
update CRAN comments
Browse files Browse the repository at this point in the history
  • Loading branch information
see24 committed Jun 23, 2023
1 parent 5603c66 commit 24c4e66
Showing 1 changed file with 19 additions and 43 deletions.
62 changes: 19 additions & 43 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,54 +1,30 @@
## Test environments
- R-hub windows-x86_64-devel (r-devel)
- R-hub ubuntu-gcc-release (r-release)
- R-hub fedora-clang-devel (r-devel)

GitHub Actions:
windows-latest (release)
macOS-latest (release)
ubuntu-20.04 (release)
ubuntu-20.04 (devel)
ubuntu-latest (release)
ubuntu-latest(devel)
ubuntu-latest(oldrel-1)

## Test environments
- R-hub windows-x86_64-devel (r-devel)
- R-hub ubuntu-gcc-release (r-release)
- R-hub fedora-clang-devel (r-devel)

## R CMD check results
❯ On windows-x86_64-devel (r-devel), ubuntu-gcc-release (r-release,
fedora-clang-devel (r-devel)
checking CRAN incoming feasibility ... [10s] NOTE
Maintainer: 'Sarah Endicott <sarah.endicott@ec.gc.ca>'

New submission

Package was archived on CRAN

Possibly misspelled words in DESCRIPTION:
Kruskal's (32:6)

CRAN repository db overrides:
X-CRAN-Comment: Archived on 2022-11-09 as requires archived package
'Require'.

❯ On windows-x86_64-devel (r-devel)
checking examples ... [14s] NOTE
Examples with CPU (user + system) or elapsed time > 5s
user system elapsed
getDistFromSource 6.92 0.17 8.28

❯ On ubuntu-gcc-release (r-release)
checking examples ... [14s/48s] NOTE
Examples with CPU (user + system) or elapsed time > 5s
user system elapsed
getDistFromSource 7.781 0.13 28.545
checking for non-standard things in the check directory ... NOTE
Found the following files/directories:
''NULL''

❯ On fedora-clang-devel (r-devel)
checking examples ... [14s/56s] NOTE
Examples with CPU (user + system) or elapsed time > 5s
user system elapsed
getDistFromSource 8.019 0.149 31.359
❯ On windows-x86_64-devel (r-devel)
checking for detritus in the temp directory ... NOTE
Found the following files/directories:
'lastMiKTeXException'

0 errors ✔ | 0 warnings ✔ | 4 notes ✖
❯ On ubuntu-gcc-release (r-release), fedora-clang-devel (r-devel)
checking HTML version of manual ... NOTE
Skipping checking HTML validation: no command 'tidy' found

* I can not reproduce the long example times for the getDistFromSource function.
It is a tiny example with only 25 raster cells and takes 0.16 seconds on my
computer. Examples were also fine with rhub::check_on_debian()
0 errors ✔ | 0 warnings ✔ | 3 notes ✖

https://builder.r-hub.io/status/roads_1.1.0.tar.gz-1b545ba8da804b4fa31841d2711d2543
These NOTES are all related to rhub issues so I believe they can be ignored

0 comments on commit 24c4e66

Please sign in to comment.