Replace unnecessarily expensive method getting chunks #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainbowdashlabs
requested changes
Aug 15, 2022
LandLord-core/src/main/java/biz/princeps/landlord/util/JavaUtils.java
Outdated
Show resolved
Hide resolved
LandLord-core/src/main/java/biz/princeps/landlord/util/JavaUtils.java
Outdated
Show resolved
Hide resolved
rainbowdashlabs
approved these changes
Aug 15, 2022
SirYwell
requested changes
Aug 18, 2022
There was a problem hiding this comment.
I don't like the approach to expose longs via API. There are already different conventions of the order, and it's pretty unintuitive (plus we currently don't expose a way to get back to the chunk coords).
For v5, I'd rather prefer to have our own lightweight Chunk object, that way we don't depend on bukkit on that aspect and we can provide a clean API.
|
Ok, interesting point of view, I acquire on this more optimal user-friendly way to to! |
Aurelien30000
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22