Skip to content

Commit

Permalink
Merge pull request #4 from Laragear/feat/php-8.4
Browse files Browse the repository at this point in the history
PHP 8.4 support
  • Loading branch information
DarkGhostHunter authored Jan 29, 2025
2 parents 6c68d92 + 8f421dd commit 4482447
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions .github/workflows/php.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ jobs:
- 8.1
- 8.2
- 8.3
- 8.4
laravel-constraint:
- 10.*
- 11.*
Expand Down
2 changes: 1 addition & 1 deletion src/RouteRedirect.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class RouteRedirect
/**
* Returns a redirection route for failed transactions
*/
public static function as(string $path, string $route = null, int $status = 303): HttpRoute
public static function as(string $path, ?string $route = null, int $status = 303): HttpRoute
{
return Route::post($path, FailureRedirectController::class)
->defaults('destination', $route ?? $path)
Expand Down
2 changes: 1 addition & 1 deletion src/Services/Concerns/DebugsTransactions.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ protected function logCreating(ApiRequest $apiRequest): void
/**
* Debugs a given operation.
*/
protected function logResponse(ApiRequest $apiRequest, Response $response, string $token = null): void
protected function logResponse(ApiRequest $apiRequest, Response $response, ?string $token = null): void
{
$context = ['api_request' => $apiRequest, 'raw_response' => $response->json()];

Expand Down

0 comments on commit 4482447

Please sign in to comment.