Open
Conversation
Contributor
|
@Monoartiam99 is attempting to deploy a commit to the larythelord's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
@LarytheLord Please check it once. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added placeholder SVGs for payment icons (visa, mastercard, paypal) to
public/images/Updated
app/page.tsxto reference the placeholders and fixed malformed JSX that caused build errors.Temporarily disabled next-pwa in development to avoid SW build/parse errors on Windows paths.
Closes Improve the footer section #87
Verification:
npm run devstarts and reports PWA disabled in development.Notes:
🎯 Rationale
This PR fixes two issues causing the dev server to fail and the footer to display missing images:
Missing payment images in the footer caused 404s and broke the visual layout.
During development, next-pwa generated a service worker that failed to parse on Windows when the repository path contains special characters (an apostrophe). That, plus accidental malformed JSX that had been inserted into [page.tsx] caused parse/runtime errors (Unterminated regexp literal / Unexpected token) preventing the app from compiling.
📝 Summary of Changes:
Added placeholder SVGs for payment icons:
public/images/visa.svg
public/images/mastercard.svg
public/images/paypal.svg
Updated [page.tsx]:
Replaced references to missing PNGs with the new SVGs.
Removed stray/malformed JSX and fixed tag balance that caused parsing errors.
Updated [next.config.mjs]:
Configured next-pwa to disable service worker generation in development using [disable: process.env.NODE_ENV !== 'production'] (PWA remains enabled in production).
🔧 Technical Details
✅ Testing
Test Details
📚 Documentation
🔄 Breaking Changes
This PR does not introduce breaking changes. PWA behavior changes only in the dev environment (disabled) and remains active in production builds.
🎨 User-Facing Changes
Frontend Changes:
Footer icons updated (appear as placeholders).
No UX workflow changes.
Backend/API Changes:
None.
📸 Screenshots:
🙏 Reviewer Notes:
Focus review on: