New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add binprot shapes for std::collections::{BTreeMap, HashMap} #8

Merged

LaurentMazare merged 1 commit into LaurentMazare:main from base1172:main

Dec 17, 2023

Contributor

base1172 commented Dec 14, 2023

This PR implements the BinProtShape trait for BTreeMap and HashMap, using the same digest calculation as in the Ocaml implementation.

Confirmed that the calculated digests for BTreeMap<i64, i64> and HashMap<i64, i64> match their Ocaml equivalents in utop:

utop # let digest = Bin_prot.Shape.eval_to_digest_string (Int.Table.bin_shape_t Int.bin_shape_t);;
val digest : string = "1fd943a5d8026fbd3e6746c972ab2127"

utop # let s = Bin_prot.Shape.eval_to_digest_string (Int.Map.bin_shape_t Int.bin_shape_t);;
val s : string = "ed73a010af8ffc32cab7411d6be2d676"


          Add binprot shapes for std::collections::{BTreeMap, HashMap}

LaurentMazare approved these changes

View reviewed changes

LaurentMazare merged commit 165b4d6 into LaurentMazare:main

14 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet