Fixing AssemblyVerifier.IsNameValid for Unicode Standard Annex 15#1094
Open
kohanis wants to merge 1 commit intoLavaGang:alpha-developmentfrom
Open
Fixing AssemblyVerifier.IsNameValid for Unicode Standard Annex 15#1094kohanis wants to merge 1 commit intoLavaGang:alpha-developmentfrom
kohanis wants to merge 1 commit intoLavaGang:alpha-developmentfrom
Conversation
HerpDerpinstine
added
Bug / Issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing identifier check according to https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/language-specification/lexical-structure#643-identifiers
Well, not actually, because
How an implementation enforces the restrictions on the allowable Unicode_Escape_Sequence values is an implementation issue.means that actually any symbol is allowed (ironically, including \0. It won't work though), but I followed what was already in place