Skip to content

Commit

Permalink
Revert "ci: give holesky-test workflow access to secrets via pull_req…
Browse files Browse the repository at this point in the history
…uest_target (#153)"

This reverts commit 15b10fd.
The commit was doing things very wrong. I hadn't understood how pull_request_target works.
Was causing the workflow to run against main branch head commit instead of PR commit.
We will need to find another solution to the problem of letting external contributors run this workflow.
  • Loading branch information
samlaf committed Oct 30, 2024
1 parent b652698 commit 67a75e4
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions .github/workflows/holesky-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,7 @@ name: holesky-test
on:
push:
branches: [ "main" ]
# pull_request_target is needed so that external contributors that create PRs from a forked repo
# have access to the secrets needed to run the tests. There are security implications to this,
# see https://stackoverflow.com/questions/74957218/what-is-the-difference-between-pull-request-and-pull-request-target-event-in-git
# MAKE SURE TO ONLY ALLOW RUNNING THIS WORKFLOW AFTER REVIEWING THE PR!
pull_request_target:
pull_request:
branches: [ "main" ]

jobs:
Expand Down

0 comments on commit 67a75e4

Please sign in to comment.