feat: OP Keccak commitment support - fix holesky test and remediate g…

…osec false positives
Layr-Labs · Jul 18, 2024 · 6fdc5d7 · 6fdc5d7
1 parent 08b2860
commit 6fdc5d7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/Makefile b/Makefile
@@ -13,6 +13,7 @@ LDFLAGSSTRING +=-X main.Version=$(VERSION)
 LDFLAGS := -ldflags "$(LDFLAGSSTRING)"
 
 E2ETEST = INTEGRATION=true go test -timeout 1m -v ./e2e -parallel 4 -deploy-config ../.devnet/devnetL1.json
+HOLESKYTEST = TESTNET=true go test -timeout 50m -v ./e2e  -parallel 4 -deploy-config ../.devnet/devnetL1.json
 
 .PHONY: eigenda-proxy
 eigenda-proxy:
@@ -41,8 +42,10 @@ e2e-test: run-minio
 	$(E2ETEST); \
 	make stop-minio
 
-holesky-test:
-	TESTNET=true go test -timeout 50m -v ./e2e  -parallel 4 -deploy-config ../.devnet/devnetL1.json
+holesky-test: run-minio
+	$(HOLESKYTEST); \
+	make stop-minio
+
 
 .PHONY: lint
 lint:

diff --git a/server/config.go b/server/config.go
@@ -39,8 +39,8 @@ const (
 	// S3 flags
 	S3BucketFlagName          = "s3.bucket"
 	S3EndpointFlagName        = "s3.endpoint"
-	S3AccessKeyIDFlagName     = "s3.access-key-id"
-	S3AccessKeySecretFlagName = "s3.access-key-secret"
+	S3AccessKeyIDFlagName     = "s3.access-key-id" // #nosec G101
+	S3AccessKeySecretFlagName = "s3.access-key-secret" // #nosec G101
 )
 
 const BytesPerSymbol = 31