Skip to content

Commit

Permalink
doc: added TODO comment for updating commitmentHeader in metric middl…
Browse files Browse the repository at this point in the history
…eware
  • Loading branch information
samlaf committed Aug 21, 2024
1 parent 3ca4b7e commit 7b5aab1
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions server/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ func WithMetrics(handleFn func(http.ResponseWriter, *http.Request) error, m metr
// where the first 3 bytes of the path are the commitment header
// commit type | da layer type | version byte
// we want to group all requests by commitment header, otherwise the prometheus metric labels will explode
// TODO: commitment header is different for non-op commitments. We will need to change this to accomodate other commitments.
// probably want (commitment mode, cert version) as the labels, since commit-type/da-layer are not relevant anyways.
commitmentHeader := r.URL.Path[:3]

Check failure on line 73 in server/server.go

View workflow job for this annotation

GitHub Actions / Linter

`accomodate` is a misspelling of `accommodate` (misspell)
recordDur := m.RecordRPCServerRequest(commitmentHeader)

Expand Down

0 comments on commit 7b5aab1

Please sign in to comment.