Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Commitment decoding bug && server handler tests #112

Merged
merged 4 commits into from
Sep 5, 2024
Merged

fix: Commitment decoding bug && server handler tests #112

merged 4 commits into from
Sep 5, 2024

Conversation

epociask
Copy link
Collaborator

@epociask epociask commented Sep 5, 2024

Fixes Issue

Fixes #

Changes proposed

  • Created IRouter and provide mock generation for interface
  • Add Make target for generating go mocks in repo
  • Added handler tests
  • Fixed commitment decoding bug which was resulting in handler process segfaulting

Screenshots (Optional)

Note to reviewers

@teddyknox teddyknox self-requested a review September 5, 2024 17:33
@epociask epociask merged commit 7959e8a into main Sep 5, 2024
7 checks passed
@epociask epociask deleted the epociask--fix-handler-tests branch September 5, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hopeyen hopeyen hopeyen left review comments

@teddyknox teddyknox teddyknox approved these changes

@bxue-l2 bxue-l2 Awaiting requested review from bxue-l2

@samlaf samlaf Awaiting requested review from samlaf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epociask @teddyknox @hopeyen