blob size metric #118
Closed
blob size metric #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bxue-l2
reviewed
Sep 16, 2024
server/config.go
Outdated
| SRSNumberToLoad: numBytes / 32, // # of fp.Elements | ||
| NumWorker: uint64(runtime.GOMAXPROCS(0)), | ||
| SRSOrder: 268435456, // 2 ^ 32 | ||
| SRSNumberToLoad: numBytes / 32, // # of fp.Elements |
|
@hopeyen what's up with this? |
Was gonna add a blob size metrics to eigenda proxy for throughput testing, but now I think there are better places where this metrics could live, perhaps EigenDA client 🤔 Since there's no clear motivation to add this metrics, I will close the PR for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a simple metric to include blob sizes when proxy handle
GETorPUTPUTfor later we could add
storeas a label and replaceStore.Stats()