This repository was archived by the owner on Jul 23, 2025. It is now read-only.
chore: bunch of small refactors for improved devex#124
Merged
Conversation
ethenotethan
approved these changes
Sep 18, 2024
Contributor
ethenotethan
left a comment
ethenotethan
left a comment
There was a problem hiding this comment.
LGTM - just a slew of knits but nothing blocking 😄
server/server.go
Outdated
| if err != nil { | ||
| svr.log.Info("failed to decode commitment", "err", err, "key", key) | ||
| w.WriteHeader(http.StatusBadRequest) | ||
| err = fmt.Errorf("failed to decode commitment from key %v (commitment mode %v): %w", key, ct, err) |
Contributor
There was a problem hiding this comment.
knit - the commitment mode string could be isolated into a single for reference across error strings
Contributor
Author
There was a problem hiding this comment.
wdym by "into a single"?
Contributor
Author
There was a problem hiding this comment.
merging this to unblock other work, but ping me to let me know what you meant and we can create another PR
server/server.go
Outdated
| @@ -159,25 +155,26 @@ func (svr *Server) Health(w http.ResponseWriter, _ *http.Request) error { | |||
| func (svr *Server) HandleGet(w http.ResponseWriter, r *http.Request) error { | |||
| ct, err := ReadCommitmentMode(r) | |||
Contributor
There was a problem hiding this comment.
knit and irrelevant to PR - ct implies CommitmentType but it should probably shorthand notation cm
cmd/server/main.go
Outdated
Comment on lines
+19
to
+21
| var Version = "unknown" | ||
| var Commit = "unknown" | ||
| var Date = "unknown" |
Contributor
There was a problem hiding this comment.
knit - could encapsulate under a single var declaration
samlaf
force-pushed
the
samlaf--devex-improvements
branch
from
0d05a6d to
2473f8e
Compare
samlaf
force-pushed
the
samlaf--devex-improvements
branch
from
624c815 to
405de62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit names for summary of changes.