feat: separate simple client into its own module #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easier to import it into other projects without importing all of the other dependencies of our root go.mod. We will first merge this PR with a replace directive in the main go.mod, then release v0.1.0 of the new client module, and then make a new PR to use that version in the main go.mod file.
samlaf
force-pushed
the
feat--separate-module-for-simple-client
branch
from
e39ffbf to
fec0efd
Compare
jianoaix
approved these changes
Dec 5, 2024
jianoaix
reviewed
Dec 5, 2024
There was a problem hiding this comment.
The client only depends on stdlib so go mod tidy doesn't generate a go.sum in this case it seems like.
EthenNotEthan
approved these changes
Dec 5, 2024
…at--separate-module-for-simple-client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier to import it into other projects without importing all of the other dependencies of our root go.mod
TODO steps:
Fixes Issue
Fixes #
Changes proposed
Screenshots (Optional)
Note to reviewers