Update EigenDA proxy to match OP v1.7.6 client expectation #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
teddyknox
commented
Jun 7, 2024
•
teddyknox
commented
- moves LoadServer() and server.go into a new server package so that LoadServer() can be used in e2e_test.go (avoiding duplication of DI efforts)
- Removes GenericCommitmentByte from the returned commitment, since it is prepended by the OP client on the clients side..?
- Enable WithLogging() middleware
- Expand WithLogging() to support error logging, update handler signatures and implementations to tie into this
- Update path patterns to match the usage by the OP plasma client
teddyknox
force-pushed
the
e2e-test-update
branch
from
c822349 to
8ccff9a
Compare
teddyknox
force-pushed
the
e2e-test-update
branch
from
8ccff9a to
3627cd2
Compare
teddyknox
changed the title
teddyknox
force-pushed
the
e2e-test-update
branch
from
8b9cf3e to
888e0cc
Compare
teddyknox
force-pushed
the
e2e-test-update
branch
from
888e0cc to
a213451
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.