feat: Batch hash verification #39
Conversation
| @@ -44,6 +47,10 @@ type Config struct { | |||
| // The blob encoding version to use when writing blobs from the high level interface. | |||
| PutBlobEncodingVersion codecs.BlobEncodingVersion | |||
|
|
|||
| // ETH vars | |||
| EthRPC string | |||
| SvcManagerAddr string | |||
There was a problem hiding this comment.
We should update the readme with a table of these addresses across Holesky and Mainnet, or even better link to the canonical EigenDA contract readme where those addresses are written down.
| @@ -73,21 +80,37 @@ func (c *Config) GetMaxBlobLength() (uint64, error) { | |||
| return c.maxBlobLengthBytes, nil | |||
| } | |||
|
|
|||
| func (c *Config) KzgConfig() *kzg.KzgConfig { | |||
| func (c *Config) VerificationCfg() *verify.Config { | |||
There was a problem hiding this comment.
Nit: Never understood why people abbreviate 'config' to remove 3 letters. Feel free to ignore.
| @@ -199,5 +224,15 @@ func CLIFlags(envPrefix string) []cli.Flag { | |||
| Usage: "Directory path to SRS tables", | |||
| EnvVars: prefixEnvVars("TARGET_CACHE_PATH"), | |||
| }, | |||
| &cli.StringFlag{ | |||
| Name: EthRPCFlagName, | |||
| Usage: "JSON RPC node endpoint for the Ethereum network used for finalizing DA blobs.", | |||
There was a problem hiding this comment.
Thoughts on putting an example RPC url in the description and a default value for a public Holesky RPC?
| &cli.StringFlag{ | ||
| Name: SvcManagerAddrFlagName, | ||
| Usage: "Deployed EigenDA service manager address.", | ||
| EnvVars: prefixEnvVars("SERVICE_MANAGER_ADDR"), |
There was a problem hiding this comment.
A default value for the Holesky address might be nice.
There was a problem hiding this comment.
I'm realizing it might be good to check into the repo certain "configuration profiles" representing good defaults for testnet and mainnet. Maybe networks/mainnet.env and networks/holesky.env. To make it the invocation of ./bin/eigenda-proxy solid state (a one liner) we would need to add a special command line flag --env-file <filepath> that let you use one of these files for settings.
| @@ -28,6 +34,7 @@ func LoadStore(cfg CLIConfig, ctx context.Context, log log.Logger) (store.Store, | |||
| return store.NewMemStore(ctx, &cfg.MemStoreCfg, verifier, log, maxBlobLength) | |||
| } | |||
|
|
|||
| log.Info("Using eigenda backend") | |||
There was a problem hiding this comment.
nit: 'EigenDA' in any user-facing outputs
| @@ -120,7 +120,7 @@ func (e *MemStore) Get(ctx context.Context, commit []byte, domain eigendacommon. | |||
| } | |||
|
|
|||
| // Don't need to do this really since it's a mock store | |||
| err = e.verifier.Verify(cert.BlobHeader.Commitment, encodedBlob) | |||
| err = e.verifier.VerifyCommitment(cert.BlobHeader.Commitment, encodedBlob) | |||
There was a problem hiding this comment.
Observation, not urgent: The fact that there's a decent amount of code duplication between the EigenDA store and memory store suggests to me that we could do some refactoring.
| return err | ||
| } | ||
|
|
||
| equal := proxy_common.EqualSlices(expectedHash[:], actualHash[:]) |
There was a problem hiding this comment.
Nit: "golang.org/x/exp/slices" gives you slices.Equal(). Again, can ignore.
https://chatgpt.com/share/79d6326a-d0e3-4192-829b-ee3064dccbc9
Pull Request Template
Fixes Issue
Fixes #
Changes proposed
Screenshots (Optional)
Note to reviewers