S3 backup #77
Merged
S3 backup #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethenotethan
reviewed
Aug 5, 2024
store/router.go
Outdated
|
|
||
| r.log.Debug("Retrieving data from eigenda") | ||
| return r.eigenda.Get(ctx, key) | ||
| if r.s3 != nil && r.s3.cfg.Backup { |
There was a problem hiding this comment.
what's the reasoning for first reading from S3 before eigenda? Shouldn't the idea be that we rollover to S3 if and only if we get an error when trying to read from the network?
There was a problem hiding this comment.
yeah thinking about this - since the blob retrieved from S3 can be verified (certified) would this elevate blob reads from the public node? Might be a good feature if it's not sacrificing security.
There was a problem hiding this comment.
if not mistaken this feature is provided to ensure resiliency for blob reads in the event that it can't be read from DA.
CC - @bxue-l2
Co-authored-by: Ethen <ethenpo@gmail.com>
Co-authored-by: Ethen <ethenpo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Fixes Issue
Fixes #
Changes proposed
This add the ability to sync blobs to S3 at the same time as Eigenda disbursement is enabled.
On retrieval the blob is fetched from S3, certificate extracted from the KEY and the blob gets verified against the cert.
Screenshots (Optional)
Note to reviewers