Skip to content

feat: payment onchain state interface #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 5, 2025
Merged

Conversation

hopeyen
Copy link
Contributor

@hopeyen hopeyen commented May 30, 2025

Why are these changes needed?

More updates will be made to the Eth Reader after new payment vault contract changes are merged. These updates are contained to meterer onchain state, mostly to track payment state by quorums.

// TODO(hopeyen): use specific quorum IDs from the chain when payment vault is updated

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@hopeyen hopeyen force-pushed the hope/payment-vault-reader branch 4 times, most recently from d2f4e96 to c0d006d Compare May 31, 2025 03:59
@hopeyen hopeyen marked this pull request as ready for review June 2, 2025 16:56
@hopeyen hopeyen requested review from dmanc, anupsv and ian-shim June 2, 2025 16:56
@hopeyen hopeyen force-pushed the hope/payment-vault-reader branch from 00be681 to 74032d1 Compare June 4, 2025 00:07
@hopeyen hopeyen merged commit 61e46ac into master Jun 5, 2025
13 checks passed
@hopeyen hopeyen deleted the hope/payment-vault-reader branch June 5, 2025 20:32
samlaf added a commit that referenced this pull request Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants