fest: support start/stop blocks for querying operator info(pubkey and socket)

[renlulu]

Fixes #259 and #312.

What Changed?

Reviewer Checklist

• Code is well-documented
• Code adheres to Go naming conventions
• Code deprecates any old functionality before removing it

[samlaf]

This looks fine to me. @shrimalmadhur do you want to start enforcing opts arguments so that we don't have breaking changes like this all the time?

[shrimalmadhur]

This looks fine to me. @shrimalmadhur do you want to start enforcing opts arguments so that we don't have breaking changes like this all the time?

yea this is getting very ugly. these seems like optional params to me - if we don't provide them, it takes default values. We should add extensible options without breaking the method arguments.

[samlaf]

Ok @renlulu synced with @shrimalmadhur , we're trying to enforce opts params going forward, such that we don't break client code everytime we add new params to a function.

Would you mind refactoring the function signatures everywhere to use a params struct instead that would for now contain the startBlock and endBlock?

type Opts struct {
   StartBlock *big.Int
   StopBlock *big.Int
}

Not sure about the exact name, Opts or Params would work, prob with a prefix related to name of function in case there's a few of them in a given module.

[renlulu]

Ok @renlulu synced with @shrimalmadhur , we're trying to enforce opts params going forward, such that we don't break client code everytime we add new params to a function.

Would you mind refactoring the function signatures everywhere to use a params struct instead that would for now contain the startBlock and endBlock?

type Opts struct {
   StartBlock *big.Int
   StopBlock *big.Int
}

Not sure about the exact name, Opts or Params would work, prob with a prefix related to name of function in case there's a few of them in a given module.

Ok, make sense, let me refactor it.

[samlaf]

this will panic if nil is passed as opts. Can we change opts to be Opts instead of *Opts?

[samlaf]

in every function

[samlaf]

Thank you!