This repository was archived by the owner on Sep 3, 2022. It is now read-only.
Damage struct now used. Ezreal + Garen updates. #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 24, 2018 08:15
Damage Structs are now used for Scripts to handle damage values, rather than them passing the raw values around.
Ezreal's W Buff for Essence Flux now appears correctly in the project file for LeagueSandbox-Default.
FurkanS1821
approved these changes
Oct 27, 2018
cntseesharp
reviewed
Nov 30, 2019
Comment on lines
+40
to
+42
| IChampion champion = target as IChampion; | ||
| if (champion != null) | ||
| { |
There was a problem hiding this comment.
Too much nesting. Have you considered (!(target is IChampion)) return;
|
Red seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Damage Structs are now used for Scripts to handle damage values, rather than them passing the raw values around. Additionally, Ezreal's W, Essence Flux, now functions as more than a projectile, while Garen's E, "Judgment", can now critically strike.
Refs #89