finish errors4

LearningOS · Jan 27, 2025 · 9a6585d · 9a6585d
1 parent 1e32a42
commit 9a6585d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/exercises/error_handling/errors3.rs b/exercises/error_handling/errors3.rs
@@ -38,5 +38,5 @@ pub fn total_cost(item_quantity: &str) -> Result<i32, ParseIntError> {
         Err(err)=>Err(err)
 
     }
-
+    
 }
diff --git a/exercises/error_handling/errors4.rs b/exercises/error_handling/errors4.rs
@@ -16,8 +16,11 @@ enum CreationError {
 
 impl PositiveNonzeroInteger {
     fn new(value: i64) -> Result<PositiveNonzeroInteger, CreationError> {
-        // Hmm...? Why is this only returning an Ok value?
-        Ok(PositiveNonzeroInteger(value as u64))
+        match value {
+            x if x < 0 => Err(CreationError::Negative),
+            0 => Err(CreationError::Zero),
+            x => Ok(PositiveNonzeroInteger(x as u64)),
+        }
     }
 }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -38,5 +38,5 @@ pub fn total_cost(item_quantity: &str) -> Result<i32, ParseIntError> {
		Err(err)=>Err(err)

		}


		}