B2CA-1584: Port Nano on NBGL #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #145 +/- ##
=======================================
Coverage 88.46% 88.46%
=======================================
Files 5 5
Lines 78 78
Branches 20 20
=======================================
Hits 69 69
Misses 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cedelavergne-ledger
force-pushed
the
cev/B2CA-1584-nbgl_nano
branch
2 times, most recently
from
aa6c075 to
1e46b7c
Compare
cedelavergne-ledger
force-pushed
the
cev/B2CA-1584-nbgl_nano
branch
2 times, most recently
from
2741150 to
555a97a
Compare
cedelavergne-ledger
force-pushed
the
cev/B2CA-1584-nbgl_nano
branch
from
555a97a to
0fc63ec
Compare
cedelavergne-ledger
requested review from
tdejoigny-ledger,
fbeutin-ledger and
agrojean-ledger
and removed request for
tdejoigny-ledger
agrojean-ledger
previously approved these changes
Jan 23, 2025
cedelavergne-ledger
force-pushed
the
cev/B2CA-1584-nbgl_nano
branch
from
0fc63ec to
8e9ae61
Compare
tests/snapshots/nanox/test_get_public_key_confirm_refused/00004.png
Outdated
Show resolved
Hide resolved
cedelavergne-ledger
force-pushed
the
cev/B2CA-1584-nbgl_nano
branch
from
8e9ae61 to
0204399
Compare
cedelavergne-ledger
force-pushed
the
cev/B2CA-1584-nbgl_nano
branch
from
0204399 to
204deaf
Compare
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: pypi/pysha3@1.0.2 |
cedelavergne-ledger
requested review from
tdejoigny-ledger and
agrojean-ledger
tdejoigny-ledger
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on old #123
AppNameandAppVersionrather than hardcoded valuepysha3bypycryptodome, and adapt tests accordinglyNote: Needs SDK adaptations, for the moment in branch LedgerHQ/ledger-secure-sdk#838