Montgomery constant #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/bc-sskr/encoding.c:249:5: warning: Declared variable-length array (VLA) has zero size [core.VLASize]
sskr_shard shards[total_shards];
^~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~
1 warning generated
…in loop condition
define memzero(...) explicit_bzero(__VA_ARGS__)
Fixes #10 Signed-off-by: Aido <aido@users.noreply.github.com>
- Sign check of bitwise operation - Comparison result is always the same
The implementation of cx_crc32_hw() on Ledger devices is buggy and produces incorrect CRC32 checks. Ledger are fixing cx_crc32_hw() on each device either through SDK or OS updates but until then cx_crc32() can be used.
Ledger have fixed their buggy implementation of CRC32 so we can start using it again
src: onboarding_seed_sskr.c: Use stable cx_crc32 instead of cx_crc32_hw
src: interpolate.c: Fix build with SDK master for LNS
[bump] v1.7.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Ignore. I created PR on wrong repo. Sorry! GitHub pull request defaults to this repo and I did not spot it in time.