-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Stax layouts for generating SSS shares #5
base: develop
Are you sure you want to change the base?
Conversation
a61079e
to
6b322dd
Compare
df70546
to
88b9ab0
Compare
f3a8838
to
b1268bb
Compare
f3f52a8
to
dcb9fab
Compare
Hi,
|
15c38de
to
72f5701
Compare
This PR depends on the fix for this issue LedgerHQ/ledger-secure-sdk#761 being available in the SDK. |
Hi, The latest push to this PR adds a port of the app to Flex. This app now works on all Ledger devices. Note Some of the automated checks are failing due to the issue described here: LedgerHQ/ledger-secure-sdk#786 |
56e6b33
to
7dfe42c
Compare
First phase of merging code that is common to all Nano devices
@aido ty for your PR. could you please add the flex target in the CI (test, build & rule enforcer) ?
|
Hi @tdejoigny-ledger , Thanks for having a look at this.
Will do.
As mentioned above the source of the issue is described here LedgerHQ/ledger-secure-sdk#786. Assuming my analysis is correct should I create a PR on ledger-secure-sdk to fix this? |
yes could be great 👍 |
Note One of the failing automated checks is fixed by this PR LedgerHQ/ledger-app-database#274 |
9ebdb32
to
36b8130
Compare
@aido still some error in the CI. |
The latest Ledger app builder container uses Nano S SDK version lns-2.1.0-v22.1. This version is from last July and does not include the above mentioned fixes to the SDK. Those fixes were cherry picked into the latest API_LEVEL_LNS but were not tagged with a version to be included in the Ledger app builder container. |
my bad: I forgot to tag the LNS branch for NanoS before publishing the new app builder |
let's wait the new app builder version |
Currently a work in progress while awaitingnbgl_useCaseKeypadDigits()
use case (see LedgerHQ/ledger-secure-sdk#601).