Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stax layouts for generating SSS shares #5

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

aido
Copy link

@aido aido commented Apr 5, 2024

Currently a work in progress while awaiting nbgl_useCaseKeypadDigits() use case (see LedgerHQ/ledger-secure-sdk#601).

@aido aido force-pushed the stax branch 2 times, most recently from a61079e to 6b322dd Compare April 20, 2024 19:27
src/stax/ui_stax.c Fixed Show fixed Hide fixed
@aido aido force-pushed the stax branch 2 times, most recently from f3f52a8 to dcb9fab Compare July 29, 2024 01:06
@aido
Copy link
Author

aido commented Jul 29, 2024

Hi,

LedgerHQ/speculos#508 is becoming a blocker for this PR.

@aido aido force-pushed the stax branch 6 times, most recently from 15c38de to 72f5701 Compare August 18, 2024 23:32
@aido aido changed the title WIP: Add Stax layouts for generating SSS shares Add Stax layouts for generating SSS shares Aug 25, 2024
@aido aido marked this pull request as ready for review August 25, 2024 21:34
@aido
Copy link
Author

aido commented Sep 4, 2024

This PR depends on the fix for this issue LedgerHQ/ledger-secure-sdk#761 being available in the SDK.

@aido
Copy link
Author

aido commented Sep 29, 2024

Hi,

The latest push to this PR adds a port of the app to Flex. This app now works on all Ledger devices.
Testing on a physical Flex device looks good.

Note

Some of the automated checks are failing due to the issue described here: LedgerHQ/ledger-secure-sdk#786

@aido aido force-pushed the stax branch 2 times, most recently from 56e6b33 to 7dfe42c Compare October 14, 2024 11:42
First phase of merging code that is common to all Nano devices
@tdejoigny-ledger
Copy link

@aido ty for your PR. could you please add the flex target in the CI (test, build & rule enforcer) ?
If NanoS is not building we will not be able to deploy it. So my suggestion here:

  • remove the nanoS from the CI+toml and we will not deployed anymore the NanoS version (we will keep the previous version)
  • OR fix the issue with the build issue with NanoS

@aido
Copy link
Author

aido commented Oct 18, 2024

Hi @tdejoigny-ledger ,

Thanks for having a look at this.

could you please add the flex target in the CI (test, build & rule enforcer) ?

Will do.

fix the issue with the build issue with NanoS

As mentioned above the source of the issue is described here LedgerHQ/ledger-secure-sdk#786. Assuming my analysis is correct should I create a PR on ledger-secure-sdk to fix this?

@tdejoigny-ledger
Copy link

Hi @tdejoigny-ledger ,

Thanks for having a look at this.

could you please add the flex target in the CI (test, build & rule enforcer) ?

Will do.

fix the issue with the build issue with NanoS

As mentioned above the source of the issue is described here LedgerHQ/ledger-secure-sdk#786. Assuming my analysis is correct should I create a PR on ledger-secure-sdk to fix this?

yes could be great 👍

@aido
Copy link
Author

aido commented Oct 21, 2024

Hi @tdejoigny-ledger,

could you please add the flex target in the CI (test, build & rule enforcer) ?

$${\color{green}✓}$$ Done

fix the issue with the build issue with NanoS

$${\color{green}✓}$$ Done. Fix also now merged into LedgerHQ/ledger-secure-sdk#808

Note

One of the failing automated checks is fixed by this PR LedgerHQ/ledger-app-database#274

@aido aido force-pushed the stax branch 2 times, most recently from 9ebdb32 to 36b8130 Compare October 24, 2024 02:17
@tdejoigny-ledger
Copy link

@aido still some error in the CI.
If I'm not wrong we already updated the SDK with the change you asked (disable USB flag)

@aido
Copy link
Author

aido commented Nov 4, 2024

Hi @tdejoigny-ledger,

The latest Ledger app builder container uses Nano S SDK version lns-2.1.0-v22.1. This version is from last July and does not include the above mentioned fixes to the SDK. Those fixes were cherry picked into the latest API_LEVEL_LNS but were not tagged with a version to be included in the Ledger app builder container.

@tdejoigny-ledger
Copy link

Hi @tdejoigny-ledger,

The latest Ledger app builder container uses Nano S SDK version lns-2.1.0-v22.1. This version is from last July and does not include the above mentioned fixes to the SDK. Those fixes were cherry picked into the latest API_LEVEL_LNS but were not tagged with a version to be included in the Ledger app builder container.

my bad: I forgot to tag the LNS branch for NanoS before publishing the new app builder

@tdejoigny-ledger
Copy link

let's wait the new app builder version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants