This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
BC2A-1408: Fix conflict name issue during APP building #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Don't forget to rebase the branch :) |
sgliner-ledger
approved these changes
Nov 13, 2023
cedelavergne-ledger
force-pushed
the
cev/B2CA-1408_conflict-name2
branch
from
31cf8ab
to
0f2bd69
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2nd round of the fix.
After fixing the BC2A-1408 (LedgerHQ/ledger-secure-sdk#445), there is a side effect in this app, because of hardcoded
dep/directory path.This PR fixes that to align with sdk update.
Note: The
scan-buildfails because ofDEPRECATEDcrypto functions