Draft
Conversation
Implements a complete Sui signer for the device SDK, replacing the @mysten/ledgerjs-hw-app-sui library. The core challenge is the Sui Ledger app's unique block protocol -- a content-addressed linked-list chunking scheme that differs from the P1/P2 chunking used by other signers. Features: - BlockProtocolTask: SHA256-chained block protocol with multi-turn APDU conversation (GET_CHUNK, PUT_CHUNK, RESULT_ACCUMULATING, RESULT_FINAL) - GetVersion, GetAddress, SignTransaction, SignPersonalMessage tasks - ProvideTrustedDynamicDescriptor for clear signing (INS 0x22) - Little-endian u32 BIP44 path encoding (Sui-specific) - Full DI wiring (Inversify), use cases, app binder, public API - 27 unit tests covering block protocol, path encoding, and all tasks Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add Sui to the signers page with support for all four operations: - Get version - Get address (with optional on-device verification) - Sign transaction (hex-encoded intent-wrapped bytes) - Sign personal message (hex-encoded intent-wrapped bytes) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…nd ContextModule Wire ContextModule through DI infrastructure (builder, container, app binder) for clear signing support. Replace CallTaskInAppDeviceAction with XState-based SignTransactionDeviceAction that supports: OpenApp → ProvideDescriptor → SignTransaction. - Add @ledgerhq/context-module and xstate dependencies - Add ContextModule to externalTypes, DI container, and SignerSuiBuilder - Add withContextModule() and originToken to SignerSuiBuilder - Add descriptor field to TransactionOptions and wire through use case - Create XState SignTransactionDeviceAction with descriptor support - Export DescriptorInput type and signTransactionDAStateSteps Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@williamrobertson13 is attempting to deploy a commit to the LedgerHQ Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.
❓ Context
✅ Checklist
Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.
🧐 Checklist for the PR Reviewers