Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👔 (dmk) [NO-ISSUE]: Update DeviceSession + WebHidTransport reconnection update #559

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

👔 (dmk) [NO-ISSUE]: Update DeviceSession + WebHidTransport reconnection update #559

wants to merge 2 commits into from
+78 −57

Conversation

valpinkman
Copy link
Member

@valpinkman valpinkman commented Dec 12, 2024 •
edited
Loading

📝 Description

This PR updates the DMK to better handle the LLD integration.

DMK
Updates the DeviceSession to handle resetting the device status when an error happens

WebHidTransport
Update the WebHidDeviceConnection for reconnection issues

❓ Context

  • JIRA or GitHub link: [NO-ISSUE] LLD integration
  • Feature:

✅ Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

@vercel Vercel
Copy link

vercel bot commented Dec 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 1:35pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
doc-device-management-kit ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 1:35pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

Messages
✅ Danger: All checks passed successfully! 🎉

Generated by 🚫 dangerJS against cc342e5

@valpinkman valpinkman force-pushed the chore/no-issue-snapshot branch from 961e621 to f0f65c6 Compare December 12, 2024 15:42
@valpinkman valpinkman force-pushed the chore/no-issue-snapshot branch from f0f65c6 to f9c9680 Compare December 19, 2024 13:52
@valpinkman valpinkman force-pushed the chore/no-issue-snapshot branch from f9c9680 to 97abaad Compare December 19, 2024 14:14
@valpinkman valpinkman force-pushed the chore/no-issue-snapshot branch from 97abaad to 98fcbbe Compare December 23, 2024 08:48
@valpinkman valpinkman force-pushed the chore/no-issue-snapshot branch from 98fcbbe to b1a1e7d Compare December 30, 2024 09:37
@valpinkman valpinkman force-pushed the chore/no-issue-snapshot branch from b1a1e7d to 76a2469 Compare December 30, 2024 13:48
@valpinkman valpinkman force-pushed the chore/no-issue-snapshot branch from 76a2469 to 14ae154 Compare December 30, 2024 15:53
@valpinkman valpinkman force-pushed the chore/no-issue-snapshot branch from 14ae154 to 90118eb Compare December 30, 2024 16:17
@valpinkman valpinkman force-pushed the chore/no-issue-snapshot branch from 90118eb to a899e28 Compare December 31, 2024 08:41
@valpinkman valpinkman force-pushed the chore/no-issue-snapshot branch from a899e28 to cba31e5 Compare December 31, 2024 10:36
@valpinkman valpinkman force-pushed the chore/no-issue-snapshot branch from cba31e5 to 09e9d51 Compare December 31, 2024 13:20
@valpinkman valpinkman changed the title 🔖 (snapshot) [NO-ISSUE]: Snapshot release 👔 (dmk) [NO-ISSUE]: Update DeviceSession + WebHidTransport reconnection update Dec 31, 2024
@valpinkman valpinkman marked this pull request as ready for review December 31, 2024 13:25
@valpinkman valpinkman requested a review from a team as a code owner December 31, 2024 13:25
@valpinkman valpinkman force-pushed the chore/no-issue-snapshot branch from 09e9d51 to b743f51 Compare January 6, 2025 08:33
ofreyssinet-ledger
ofreyssinet-ledger approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix 👍

@valpinkman valpinkman force-pushed the chore/no-issue-snapshot branch from b743f51 to f31fb01 Compare January 6, 2025 15:47
@valpinkman valpinkman force-pushed the chore/no-issue-snapshot branch from f31fb01 to 689d171 Compare January 6, 2025 15:55
@valpinkman valpinkman force-pushed the chore/no-issue-snapshot branch from 689d171 to cc342e5 Compare January 10, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofreyssinet-ledger ofreyssinet-ledger ofreyssinet-ledger approved these changes

Assignees

@valpinkman valpinkman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valpinkman @ofreyssinet-ledger