✨ (signer-btc) [DSDK-471]: SignPsbt task #581
Open
+2,544
−907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
jdabbech-ledger
force-pushed
the
feat/dsdk-471-sign-psbt-task
branch
from
9cce5af to
47b61b5
Compare
jdabbech-ledger
force-pushed
the
feat/dsdk-471-sign-psbt-task
branch
from
0034834 to
7182bae
Compare
jdabbech-ledger
force-pushed
the
feat/dsdk-471-sign-psbt-task
branch
from
7182bae to
76bdcfd
Compare
jdabbech-ledger
force-pushed
the
feat/dsdk-471-sign-psbt-task
branch
from
f08eb42 to
c922a05
Compare
jdabbech-ledger
force-pushed
the
feat/dsdk-471-sign-psbt-task
branch
from
c922a05 to
0663f38
Compare
aussedatlo
reviewed
Jan 8, 2025
| }, | ||
| initialValues: { | ||
| derivationPath: DEFAULT_DERIVATION_PATH, | ||
| psbt: "70736274ff0104010101fb0402000000010204020000000105010100011004000000000103040100000001007102000000013daeeb9a92e7b5af90c787d53f0e60d2cf4cfd47bca9a0d8bc77a7464b024c0b00000000000000000002ff0300000000000016001402fe597c6ec0e2982712929bcf079a4e11d37e8d950b0000000000001600144dc432cb6a26c52a1e6ddd2bcf0ee49199fae0cc000000002206031869567d5e88d988ff7baf6827983f89530ddd79dbaeadaa6ec538a8f03dea8b18f5acc2fd540000800000008000000080000000000000000001011fff0300000000000016001402fe597c6ec0e2982712929bcf079a4e11d37e8d010e200cf08d04fa11ff024d5a50165ba65e495409b50ba6657788dfa15274adb682df010f0400000000000103086b01000000000000010416001429159115f12bb6a7e977439c83d3f8d555d72d5f00", |
There was a problem hiding this comment.
[COULD] Remove the default psbt here
There was a problem hiding this comment.
ok, it's a heartache after so much difficulties to create it 😿
|
|
||
| export type SignPsbtDAInternalState = { | ||
| readonly error: SignPsbtDAError | null; | ||
| // [SHOULD] be psbt instead of signature |
There was a problem hiding this comment.
[ASK] What to do with this comment ?
There was a problem hiding this comment.
The next task I'm working on, UpdatePsbtTask, will modify this device action to return a psbt instead of a Signature
| { | ||
| constructor(private readonly args: GetWalletAddressCommandArgs) {} | ||
| constructor( | ||
| private readonly args: GetWalletAddressCommandArgs, |
There was a problem hiding this comment.
[COULD] rename args to _args
| @@ -41,19 +37,26 @@ export type SignMessageCommandArgs = { | |||
| readonly messageMerkleRoot: Uint8Array; | |||
| }; | |||
|
|
|||
| export type SignMessageCommandResponse = Signature | ApduResponse; | |||
| export type SignMessageCommandResponse = ApduResponse; | |||
There was a problem hiding this comment.
[ASK] Why returning an ApduResponse instead of a Signature ?
There was a problem hiding this comment.
To handle the signature only in the task, with a client interpreter flow as the it should respond with those client commands.
| psbt, | ||
| }); | ||
| } | ||
| } |
There was a problem hiding this comment.
[SHOULD] test file missing for this!
jdabbech-ledger
force-pushed
the
feat/dsdk-471-sign-psbt-task
branch
from
02dd40e to
f9c201f
Compare
jdabbech-ledger
force-pushed
the
feat/dsdk-471-sign-psbt-task
branch
from
f9c201f to
4f01dfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
❓ Context
✅ Checklist
Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.
🧐 Checklist for the PR Reviewers